Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript generator: Use string type as the discriminator property type in specialized interfaces #1718

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

RicoSuter
Copy link
Owner

@RicoSuter RicoSuter commented Jul 17, 2024

New

export interface Base {
    Type: EBase;
}

export type EBase = "OneChild" | "SecondChild";

export interface OneChild extends Base {
    A: string;
    Type: 'OneChild';
}

export interface SecondChild extends Base {
    B: string;
    Type: 'SecondChild';
}

export interface MyClass {
    Child: Base;
    Children: Base[];
}

Before

export interface Base {
    Type: EBase;
}

export type EBase = "OneChild" | "SecondChild";

export interface OneChild extends Base {
    A: string;
    Type: EBase;
}

export interface SecondChild extends Base {
    B: string;
    Type: EBase;
}

export interface MyClass {
    Child: Base;
    Children: Base[];
}

@RicoSuter RicoSuter merged commit 9bf8f69 into master Jul 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant